| *** mlncn has joined #npoacct | 00:33 | |
| *** mlncn has quit IRC | 00:43 | |
| *** bkuhn is now known as bkuhnIdle | 01:30 | |
| *** mlncn has joined #npoacct | 02:02 | |
| *** bkuhnIdle is now known as bkuhn | 02:20 | |
| *** garrison has joined #npoacct | 03:03 | |
| *** garrison has joined #npoacct | 03:03 | |
| *** mlncn has quit IRC | 03:10 | |
| *** garrison has quit IRC | 04:44 | |
| *** garrison has joined #npoacct | 04:45 | |
| *** tgnitidle has joined #npoacct | 05:15 | |
| *** tgnit has quit IRC | 05:18 | |
| *** garrison has quit IRC | 05:44 | |
| *** garrison has joined #npoacct | 05:45 | |
| *** garrison has quit IRC | 06:45 | |
| *** garrison has joined #npoacct | 06:46 | |
| *** garrison has quit IRC | 07:47 | |
| *** tgnit has joined #npoacct | 09:21 | |
| *** tgnitidle has quit IRC | 09:21 | |
| *** garrison has joined #npoacct | 11:03 | |
| *** tgnit has quit IRC | 12:34 | |
| *** tgnit has joined #npoacct | 12:34 | |
| *** nesciens has joined #npoacct | 13:40 | |
| *** garrison has quit IRC | 14:13 | |
| tbm | tgnit: so how about you start with something easy | 14:15 |
|---|---|---|
| tbm | tgnit: 1) implement a commodity directive... just the parsing of the directive, not the actual implementation of rounding | 14:16 |
| tbm | tgnit: 2) a command line option. again, just the parsing using OPT() and OPTION() | 14:16 |
| bkuhn | Yes, this sounds like a good idea to me. :) | 14:16 |
| tbm | tgnit: in the meantime, I'll draft up a proposal on how to properly fix the rounding issue | 14:16 |
| tgnit | tbm: i started with debugging and i am also thinking along the same line as yours | 14:16 |
| tbm | tgnit: if you have some time, you could also write some test cases NOT relaed to rounding | 14:16 |
| tgnit | doing the directive thing | 14:17 |
| tbm | tgnit: ok | 14:17 |
| tbm | tgnit: start in src/textual.cc | 14:17 |
| bkuhn | tgnit: tbm makes a good suggestion in that we can see some real output from that work. It's important that we see some code given that midterm evaluation is soon. | 14:17 |
| tgnit | tbm: such as? | 14:17 |
| tbm | tgnit: I know some of this code, so I can provide some help (I hope) | 14:17 |
| bkuhn | tgnit: can you try to do what tbm suggests in the next day or so and publish a branch publicly on your github page that does it? | 14:17 |
| tgnit | bkuhn ;agreed | 14:17 |
| bkuhn | (just in your own fork of the ledger-cli repository) | 14:17 |
| tgnit | yes | 14:18 |
| tbm | tgnit: well, just look for things that are currently not being tested. for example, hereare some empty test files | 14:18 |
| bkuhn | tgnit: great, ping me and tbm tomorrow with the results, please! | 14:18 |
| tgnit | absolutely | 14:18 |
| tbm | ls -l test/*/*test | grep ' 0 ' | 14:18 |
| tbm | -rw-r--r-- 1 tbm tbm 0 May 18 09:34 test/baseline/opt-cleared-format.test | 14:18 |
| tbm | -rw-r--r-- 1 tbm tbm 0 May 18 09:34 test/baseline/opt-date.test | 14:18 |
| tbm | -rw-r--r-- 1 tbm tbm 0 May 18 09:34 test/baseline/opt-datetime-format.test | 14:18 |
| tbm | ... | 14:18 |
| tbm | adding tests for these would be a good and easy start | 14:18 |
| tbm | 1) figure out what the options do (read manual, code, test) | 14:18 |
| tbm | 2) add some test case | 14:19 |
| tgnit | ok | 14:19 |
| tbm | but start with the commodity directive | 14:19 |
| tgnit | tbm: yes | 14:19 |
| bkuhn | I agree with tbm on that point too. Maybe work on two branches: (1) to start implementing the feature, just doing the directive and command line options but no "guts" yet and (2) on writing the tests. | 14:21 |
| tbm | tgnit: yeah, start with 1) adding a commodity directive | 14:23 |
| tbm | look at src/textual.cc | 14:23 |
| bkuhn | tgnit: But, focus on (1) for the next day or so. Don't try to do too many things at once. There's lots to be done. | 14:23 |
| tbm | look for instance_t::commodity_directive | 14:23 |
| tbm | on line 1065 | 14:23 |
| tgnit | bkuhn: got you | 14:23 |
| tbm | you can see stuff like: | 14:23 |
| tbm | if (keyword == "alias") | 14:23 |
| tbm | commodity_alias_directive(*commodity, b); | 14:23 |
| tbm | add something new here, e.g. "rounding" | 14:23 |
| bkuhn | tgnit: great. :) | 14:23 |
| tbm | then create a function commodity_rounding_directive | 14:23 |
| tgnit | rbm: looking | 14:23 |
| tbm | imho that should take an integer as value | 14:24 |
| tbm | produce a parsing error otherwise | 14:24 |
| tgnit | tbm:ok, integer as in precision as we talked? | 14:25 |
| tbm | yes | 14:25 |
| tgnit | tbm:keyword is precision then call commodity precision directive | 14:32 |
| bkuhn | This sounds like a plan. I look forward to doing a code review tomorrow.;) | 14:32 |
| tgnit | bkuhn: me too | 14:34 |
| tbm | tgnit: ok | 14:38 |
| *** mlncn has joined #npoacct | 14:44 | |
| *** mlncn has quit IRC | 15:20 | |
| *** mlncn has joined #npoacct | 15:22 | |
| *** tgnitt has joined #npoacct | 17:13 | |
| *** mlncn has quit IRC | 17:33 | |
| *** mlncn has joined #npoacct | 17:48 | |
| *** mlncn has quit IRC | 18:09 | |
| *** tgnitt has quit IRC | 19:06 | |
| *** mlncn has joined #npoacct | 19:13 | |
| *** garrison has joined #npoacct | 19:24 | |
| *** tgnitidle has joined #npoacct | 19:47 | |
| *** tgnit has quit IRC | 19:48 | |
| *** nesciens has quit IRC | 19:49 | |
| *** bkuhn has quit IRC | 20:08 | |
| *** bkuhn has joined #npoacct | 20:10 | |
| *** bkuhn has quit IRC | 20:14 | |
| *** bkuhn has joined #npoacct | 20:16 | |
| *** bkuhn has quit IRC | 20:33 | |
| *** bkuhn has joined #npoacct | 20:45 | |
| *** bkuhn is now known as bkuhnIdle | 20:50 | |
| *** garrison has quit IRC | 22:11 | |
| *** garrison has joined #npoacct | 22:12 | |
| *** tbm has quit IRC | 22:46 | |
| *** bkuhnIdle is now known as bkuhn | 22:57 | |
| *** garrison has quit IRC | 23:12 | |
| *** garrison has joined #npoacct | 23:24 | |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!