*** tgnit has joined #npoacct | 00:28 | |
*** mlncn-agaric has quit IRC | 01:08 | |
*** mlncn-agaric has joined #npoacct | 01:40 | |
*** mlncn-agaric has quit IRC | 01:46 | |
*** benjamin-agaric has joined #npoacct | 01:46 | |
*** bkuhn is now known as bkuhnIdle | 01:48 | |
*** benjamin-agaric has quit IRC | 01:57 | |
*** bkuhnIdle is now known as bkuhn | 02:56 | |
*** benjamin-agaric has joined #npoacct | 03:52 | |
*** bkuhn has quit IRC | 03:52 | |
*** tgnit has quit IRC | 05:07 | |
*** tgnit has joined #npoacct | 05:07 | |
*** tgnitidle has joined #npoacct | 05:12 | |
*** tgnit has quit IRC | 05:12 | |
*** tgnitidle has quit IRC | 05:18 | |
*** tgnit has joined #npoacct | 05:24 | |
*** benjamin-agaric has quit IRC | 05:38 | |
*** nesciens has quit IRC | 05:59 | |
*** tgnitidle has joined #npoacct | 11:18 | |
*** tgnit has quit IRC | 11:18 | |
*** tgnitidle has quit IRC | 11:23 | |
*** tgnit has joined #npoacct | 11:27 | |
*** benjamin-agaric has joined #npoacct | 11:54 | |
*** tgnitidle has joined #npoacct | 13:13 | |
*** tgnit has quit IRC | 13:14 | |
*** benjamin-agaric has quit IRC | 13:15 | |
*** jelmer has quit IRC | 14:30 | |
*** jelmer has joined #npoacct | 14:30 | |
*** tgnitidle has quit IRC | 15:24 | |
*** tgnit has joined #npoacct | 15:26 | |
*** bkuhn has joined #npoacct | 15:37 | |
*** benjamin-agaric has joined #npoacct | 15:49 | |
*** benjamin-agaric has quit IRC | 19:20 | |
*** bkuhn is now known as bkuhnIdle | 19:35 | |
*** bkuhnIdle is now known as bkuhn | 19:55 | |
*** benjamin-agaric has joined #npoacct | 19:56 | |
tgnit | bkuhn: greetings! | 19:57 |
---|---|---|
bkuhn | greetings, tgnit ! | 19:59 |
bkuhn | I haven't looked at your recent patches yet, I apologize. | 20:00 |
bkuhn | Can you email me some URLs of some good parts to review? | 20:00 |
tgnit | bkuhn: no problem, i will do but i have a doubt | 20:07 |
tgnit | there is one place in both patches which overlap | 20:08 |
tgnit | bkuhn: while testing i came to know that if i don't keep that in the new patch, the displayed amounts contains the unrounded amount but calculation is done after rounding so results are correct | 20:09 |
tgnit | bkuhn: keeping it make unnecessary rounding. | 20:11 |
tgnit | i mean redundant calls | 20:11 |
bkuhn | hmmm. | 20:12 |
bkuhn | ok, put that in the email to me if you don't mind | 20:12 |
bkuhn | I'll look closer when I download it | 20:12 |
tgnit | bkuhn: i feel i should be looking at some other place too, where only displayed amount are rounded without overlapping to avoid redundancy, so should i keep this block for now? | 20:12 |
tgnit | sure | 20:12 |
bkuhn | I'm not sure, is johnw still not back? | 20:13 |
tgnit | in the new patch right now it is not there, i send you both | 20:13 |
bkuhn | ok, great. | 20:16 |
bkuhn | I'll look for it later today or tomorrow, and send you patch review | 20:16 |
bkuhn | sorry I'm a few days behind | 20:16 |
tgnit | bkuhn: no problem | 20:17 |
tbm | I'm not really online, but I can confirm that johnw is back | 20:32 |
tgnit | tbm: i have attached the new patch on the rounding post on ledger | 20:35 |
*** benjamin-agaric has quit IRC | 22:33 | |
*** benjamin-agaric has joined #npoacct | 22:34 | |
*** benjamin-agaric is now known as mlncn | 22:34 | |
paroneayea | b | 23:12 |
paroneayea | oops | 23:12 |
paroneayea | buffer switch fail | 23:12 |
*** nesciens has joined #npoacct | 23:47 | |
*** mlncn has quit IRC | 23:54 |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!