| *** tgnitidle has quit IRC | 06:29 | |
| *** tgnit has joined #npoacct | 07:03 | |
| *** tgnit has quit IRC | 09:33 | |
| *** tgnit has joined #npoacct | 09:46 | |
| *** tgnit has quit IRC | 09:57 | |
| *** tgnit has joined #npoacct | 10:00 | |
| *** tgnit has quit IRC | 10:28 | |
| *** tgnit has joined #npoacct | 10:59 | |
| *** tgnit has quit IRC | 11:04 | |
| *** tgnit has joined #npoacct | 11:13 | |
| *** bkuhn has joined #npoacct | 15:29 | |
| tgnit | bkuhn: greetings! | 15:32 |
|---|---|---|
| bkuhn | i. | 15:32 |
| bkuhn | greetings. | 15:32 |
| tgnit | i have submitted lot of tests and will submit more, but some of my output is different from Travis - ci build. | 15:35 |
| tgnit | tests passes on my system | 15:35 |
| bkuhn | are you sure you're building against master? | 15:37 |
| tgnit | yes.. | 15:39 |
| tgnit | i first rebase on upstream master | 15:39 |
| tgnit | infact i redownloaded and reinstalled ledger to test.. | 15:40 |
| tgnit | but still the same result. | 15:40 |
| bkuhn | what are the specific differences? | 15:43 |
| tgnit | mainly printing in report, earlier, output was different for a reg --lot-prices --equity test and now i dump print balance, the commodities are in different order | 15:47 |
| tgnit | checked various failed reports at https://travis-ci.org/ledger/ledger/pull_requests | 15:48 |
| * bkuhn looks | 15:48 | |
| bkuhn | ok, I'll pull your branch too and look. | 15:51 |
| bkuhn | tgnit: are all your tests all on your master branch now? | 15:53 |
| tgnit | code_coverage branch | 15:53 |
| tgnit | rebased on master | 15:53 |
| bkuhn | last commit is 689112d3c0ffeb895ad4d8b9f61b50c5f537f0ed ? | 15:54 |
| bkuhn | (just making sure I'm looking at the right thign) | 15:55 |
| bkuhn | tgnit: ^^^ I'm rebuilding at that commit id from scratch | 15:55 |
| tgnit | yes | 15:58 |
| tgnit | before the tests | 15:58 |
| bkuhn | ?? | 15:59 |
| bkuhn | Ah, ok | 15:59 |
| bkuhn | 272e3cb3799937dcd3c379de56b299a3cbde52ca is your last test commit? | 15:59 |
| bkuhn | tgnit: ^ | 15:59 |
| tgnit | yes | 15:59 |
| bkuhn | ok, building from there and will look at test reports when it's done | 16:00 |
| tgnit | sure | 16:00 |
| tgnit | bkuhn: any luck? | 17:34 |
| bkuhn | I launched the tests running and was working on something else. I'll look at output now | 17:58 |
| bkuhn | tgnit: I get: | 18:21 |
| bkuhn | The following tests FAILED: | 18:21 |
| bkuhn | 2 - LedgerMathTests (Failed) | 18:21 |
| bkuhn | Errors while running CTest | 18:21 |
| bkuhn | make: *** [test] Error 8 | 18:21 |
| bkuhn | 18:21 | |
| bkuhn | Is that what you get when you run it on your own? | 18:21 |
| tgnit | no, it passes easily.. | 18:22 |
| bkuhn | Ok, so that's what I get on the command line | 18:22 |
| tgnit | i have run clean build too with same output | 18:23 |
| tgnit | i mean it passes on my system. | 18:24 |
| bkuhn | FWIW, I ran: | 18:24 |
| bkuhn | git clean -dfx; ./acprep --prefix=/home/bkuhn/hacks/Installs/TripunLedger3 --python --jobs=2 debug make ; make tests | 18:24 |
| tgnit | shall i change the output to what Travis give then? | 18:26 |
| tgnit | i will try clear my system then | 18:27 |
| bkuhn | I think you need to figure out why you get a different result. | 18:27 |
| bkuhn | Something is very wrong if you get a different result than both me and Travis. | 18:27 |
| bkuhn | tgnit: Is there a verbose option I can give the test process that would help you? | 18:27 |
| tgnit | i ran with that.. i know what output is different. | 18:28 |
| tgnit | i will try once again with a cleaned system. | 18:29 |
| bkuhn | ok, I was saying if I run it, it might give you moreinfo. | 18:30 |
| bkuhn | (I don't actually know how to get verbose output on the tests) | 18:30 |
| bkuhn | how do you do it? | 18:31 |
| tgnit | ctest - V | 18:32 |
| bkuhn | ah, | 18:32 |
| bkuhn | so make check just calls ctest. :) | 18:32 |
| bkuhn | I wasn't sure how it did it. :) | 18:32 |
| tgnit | bkuhn: one thing more, shall i try adding unit test for value_t? right now it is not there in mathtests | 18:36 |
| tgnit | ctest -V -R Math | 18:37 |
| tgnit | run only mathtests | 18:37 |
| bkuhn | Ok, I get: | 18:37 |
| bkuhn | 18:37 | |
| bkuhn | 2: Test command: /home/bkuhn/hacks/ledger/MathTests | 18:37 |
| bkuhn | 2: Test timeout computed to be: 9.99988e+06 | 18:37 |
| bkuhn | 2: Running 71 test cases... | 18:37 |
| bkuhn | 2: /home/bkuhn/hacks/ledger/test/unit/t_balance.cc(549): error in "testPrinting": check std::string("BALANCE(EUR 456, $ 123.00)") == bufstr.str() failed [BALANCE(EUR 456, $ 123.00) != BALANCE($ 123.00, EUR 456)] | 18:37 |
| bkuhn | 2: | 18:37 |
| bkuhn | 2: *** 1 failure detected in test suite "math" | 18:37 |
| bkuhn | 1/1 Test #2: LedgerMathTests ..................***Failed 0.09 sec | 18:37 |
| bkuhn | 18:38 | |
| bkuhn | which seems to be the same error as in Travis? | 18:38 |
| tgnit | yes | 18:38 |
| bkuhn | tgnit: as for value_t, I'm much more familiar with the regression tests than the unit test.... why are you asking if you should try that in particular? I'm generally fine with you adding any tests you find useful. | 18:38 |
| bkuhn | (and cover code not yet covered) | 18:39 |
| tgnit | there are some uncalled functions and unused branches in value.cc i thought may be i could cover it with unit testing | 18:40 |
| bkuhn | That seems to me useful; I can't think of an obvious reason why not. Can you>? | 18:48 |
| tgnit | bkuhn: i try add as many as i can. | 18:49 |
| bkuhn | ok. | 18:50 |
| tgnit | i will discuss with johnw or tbm if it is fine to add it under mathtests | 18:50 |
| tgnit | bkuhn: including this printing test, once fixed it 25 tests i think, way to go :) | 18:57 |
| bkuhn | tgnit: (re putting value.cc tests under math tests) Yeah, I'm not completely sure about the unit test structure. johnw is definitely the one to ask. If he's not around, I'd suggest submitting it that way in the PR and note that you weren't sure, and he'll tell you if it belongs somewhere else. | 18:58 |
| tgnit | hmm | 18:58 |
| bkuhn | tgnit: (re: 25 tests): good, and I see some have been accepted by johnw upstream already, I haven't counted how many though. | 18:58 |
| tgnit | bkuhn: please do tell me if you feel the count is different. | 18:59 |
| bkuhn | I'll take a look. | 19:01 |
| tgnit | ok | 19:01 |
| bkuhn | tgnit: I agree with your overall count of 25 in the tripun/code_coverage branch. | 19:05 |
| tgnit | thanks | 19:05 |
| bkuhn | tgnit: It seems that at least 10 have been accepted upstream, but I'd really prefer if you could get all 35 you write accepted upstream -- particularly figuring out why your equity test fails for everyone else but you. | 19:10 |
| tgnit | bkuhn: i will add t_value.cc to mathtests and create a pull request for johnw to review | 19:10 |
| tgnit | bkuhn: ok | 19:10 |
| *** bkuhn is now known as bkuhnIdle | 19:55 | |
| *** bkuhnIdle is now known as bkuhn | 20:42 | |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!