| *** mlncn has quit IRC | 00:49 | |
| *** mlncn has joined #npoacct | 00:49 | |
| *** mlncn has quit IRC | 00:59 | |
| *** bkuhn is now known as bkuhnIdle | 01:16 | |
| *** mlncn has joined #npoacct | 01:17 | |
| *** bkuhnIdle is now known as bkuhn | 02:03 | |
| *** bkuhn has joined #npoacct | 02:08 | |
| *** mlncn has quit IRC | 02:17 | |
| *** nesciens has quit IRC | 02:22 | |
| *** bkuhn has quit IRC | 03:09 | |
| *** mlncn has joined #npoacct | 03:55 | |
| *** tgnit has quit IRC | 05:37 | |
| *** mlncn has quit IRC | 05:58 | |
| *** tgnit has joined #npoacct | 06:00 | |
| *** tgnit has quit IRC | 06:36 | |
| *** tgnit has joined #npoacct | 06:40 | |
| *** tgnit has quit IRC | 10:26 | |
| *** tgnit has joined #npoacct | 10:36 | |
| *** tgnitidle has joined #npoacct | 11:10 | |
| *** tgnit has quit IRC | 11:13 | |
| *** mlncn has joined #npoacct | 13:00 | |
| *** tgnitidle has quit IRC | 15:20 | |
| *** bkuhn has joined #npoacct | 15:33 | |
| *** tgnit has joined #npoacct | 15:37 | |
| *** scott_gonzalez has quit IRC | 15:48 | |
| *** scott_gonzalez has joined #npoacct | 16:01 | |
| bkuhn | tgnit: I just sent you an email. I think you should prepare your feature for a pull request upstream. | 16:03 |
|---|---|---|
| bkuhn | But you should put the tests together with the feature and submit it as one pull requests | 16:03 |
| tgnit | bkuhn: yes, another good news, benchmark shows negligible difference :) | 16:05 |
| bkuhn | that's good. | 16:05 |
| bkuhn | You may want to submit the benchmark results in the text of your pull requests... | 16:05 |
| tgnit | bkuhn: i used time command, any tip to prepare benchmark report? | 16:05 |
| bkuhn | ... so upstream knows your new feature won't impact the users. | 16:05 |
| bkuhn | time is fine for this purpose, I think. | 16:05 |
| tgnit | yes | 16:05 |
| bkuhn | Here's what suggest: | 16:05 |
| bkuhn | merge your commits of the test file (maybe with git cherry-pick) into your master branch with the feature in it. | 16:06 |
| bkuhn | make sure you rebase against current master upstream (fix any problems if you encounter them) | 16:06 |
| bkuhn | then, submit a pull request. | 16:06 |
| bkuhn | I'm happy to examine your master branch right before you do it to make sure it looks good. | 16:06 |
| bkuhn | the benchmark details can go in the description of the pull request on GitHub (you can explain that the feature does not appear to impact users who don't use the feature) | 16:07 |
| tgnit | bkuhn: i am planning to create a branch with my patch and tests and then propose a merge? | 16:08 |
| tgnit | ok | 16:08 |
| bkuhn | tgnit: that sounds very good. I'm happy to review your branch before you submit the merge request. | 16:12 |
| tgnit | bkuhn: the tests are a part of debug branch because i will combine all the tests into one before making a pull request. i will surely get it verified by you before i do it | 16:13 |
| bkuhn | Yeah, that sounds fine. | 16:14 |
| *** bkuhn is now known as bkuhnIdle | 19:53 | |
| *** nesciens has joined #npoacct | 19:56 | |
| *** bkuhnIdle is now known as bkuhn | 20:31 | |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!