Wednesday, 2014-07-09

*** mlncn has quit IRC00:49
*** mlncn has joined #npoacct00:49
*** mlncn has quit IRC00:59
*** bkuhn is now known as bkuhnIdle01:16
*** mlncn has joined #npoacct01:17
*** bkuhnIdle is now known as bkuhn02:03
*** bkuhn has joined #npoacct02:08
*** mlncn has quit IRC02:17
*** nesciens has quit IRC02:22
*** bkuhn has quit IRC03:09
*** mlncn has joined #npoacct03:55
*** tgnit has quit IRC05:37
*** mlncn has quit IRC05:58
*** tgnit has joined #npoacct06:00
*** tgnit has quit IRC06:36
*** tgnit has joined #npoacct06:40
*** tgnit has quit IRC10:26
*** tgnit has joined #npoacct10:36
*** tgnitidle has joined #npoacct11:10
*** tgnit has quit IRC11:13
*** mlncn has joined #npoacct13:00
*** tgnitidle has quit IRC15:20
*** bkuhn has joined #npoacct15:33
*** tgnit has joined #npoacct15:37
*** scott_gonzalez has quit IRC15:48
*** scott_gonzalez has joined #npoacct16:01
bkuhntgnit: I just sent you an email.  I think you should prepare your feature for a pull request upstream.16:03
bkuhnBut you should put the tests together with the feature and submit it as one pull requests16:03
tgnitbkuhn: yes,  another good news, benchmark shows negligible difference :)16:05
bkuhnthat's good.16:05
bkuhnYou may want to submit the benchmark results in the text of your pull requests...16:05
tgnitbkuhn:  i used time command,  any tip to prepare benchmark report?16:05
bkuhn... so upstream knows your new feature won't impact the users.16:05
bkuhntime is fine for this purpose, I think.16:05
bkuhnHere's what suggest:16:05
bkuhnmerge your commits of the test file (maybe with git cherry-pick) into your master branch with the feature in it.16:06
bkuhnmake sure you rebase against current master upstream (fix any problems if you encounter them)16:06
bkuhnthen, submit a pull request.16:06
bkuhnI'm happy to examine your master branch right before you do it to make sure it looks good.16:06
bkuhnthe benchmark details can go in the description of the pull request on GitHub (you can explain that the feature does not appear to impact users who don't  use the feature)16:07
tgnitbkuhn:  i am planning to create a branch with my patch and tests and then propose a merge?16:08
bkuhntgnit: that sounds very good.  I'm happy to review your branch before you submit the merge request.16:12
tgnitbkuhn:  the tests are a part of debug branch because i will combine all the tests into one before making a pull request.  i will surely get it verified by you before i do it16:13
bkuhnYeah, that sounds fine.16:14
*** bkuhn is now known as bkuhnIdle19:53
*** nesciens has joined #npoacct19:56
*** bkuhnIdle is now known as bkuhn20:31

Generated by 2.12.1 by Marius Gedminas - find it at!