| *** mlncn has quit IRC | 00:27 | |
| *** mlncn has joined #npoacct | 01:02 | |
| *** mlncn has quit IRC | 01:08 | |
| *** mlncn has joined #npoacct | 01:12 | |
| *** bkuhn has quit IRC | 03:00 | |
| *** mlncn has quit IRC | 03:56 | |
| *** nesciens has quit IRC | 04:34 | |
| *** mlncn has joined #npoacct | 05:34 | |
| *** tbm has quit IRC | 06:27 | |
| *** tbm_ has joined #npoacct | 08:23 | |
| *** mlncn has quit IRC | 11:00 | |
| *** mlncn has joined #npoacct | 13:58 | |
| *** bkuhn has joined #npoacct | 16:04 | |
| *** mlncn has quit IRC | 16:24 | |
| *** tbm_ is now known as tbm | 16:30 | |
| *** mlncn has joined #npoacct | 17:06 | |
| *** mlncn has quit IRC | 18:38 | |
| *** bkuhn is now known as bkuhnIdle | 19:14 | |
| *** mlncn has joined #npoacct | 19:29 | |
| *** mlncn has quit IRC | 19:42 | |
| *** mlncn has joined #npoacct | 20:04 | |
| *** bkuhnIdle is now known as bkuhn | 20:05 | |
| tgnit | bkuhn: https://github.com/tripun/ledger/compare/feature_precision | 20:47 |
|---|---|---|
| tgnit | please review | 20:47 |
| tbm | tgnit: is there a reason you're still not following coding standards? | 20:48 |
| tbm | e,g, | 20:48 |
| tbm | if(has_commodity( | 20:48 |
| tbm | should be: if (... | 20:49 |
| tbm | in src/amount.cc you're add a blank line for no reason | 20:49 |
| tbm | in src/values.cc the intentation is wrong | 20:49 |
| tbm | + if(as_amount().has_commodity() && as_amount().commodity().has_flags(COMMODITY_SET_CUSTOM_PRECISION)) { | 20:50 |
| tbm | + amount_t temp(as_amount()); | 20:50 |
| tbm | the stuff in brackets {} should be intended | 20:50 |
| tgnit | tbm: sorry to annoy you | 20:50 |
| tgnit | got you | 20:50 |
| tbm | you're not annoying me. I'm just providing feedback | 20:51 |
| tbm | sorry for annoying you :) | 20:51 |
| tbm | also, is there a reason you only added one test instead of al? | 20:51 |
| tgnit | tbm: i corrected what i know of, but did not observed this. | 20:51 |
| tbm | anyway, I'm back now.... quite curious to test this patch on my ledger data | 20:52 |
| tgnit | i combined all of them to one test, usually baseline has one test per feature | 20:52 |
| tbm | right | 20:53 |
| tgnit | tbm: please do and it does not affect speed noticeably | 20:54 |
| tgnit | negligible | 20:54 |
| tgnit | tbm: i had trouble with git it is adding that empty line for no reason i can guess of | 20:55 |
| tbm | try removing it | 20:59 |
| * bkuhn agrees with tbm's comments. | 21:01 | |
| bkuhn | I don't know whether it's better or not to combine all of it into one test. | 21:01 |
| tbm | one option would be to add a simple test as test/baseline/dir-commodity-precision.test | 21:01 |
| tbm | and then add the other test cases as test/regress/xxx-a.test, xxx-b.test | 21:02 |
| tbm | xxx being the bug number | 21:02 |
| tgnit | tbm: it does not annoy me, but thanks i will observe these things from now on. i have amended the commit. please check once again | 21:13 |
| tgnit | tbm: alright, should i separate them then? i also feel combining it up will make it difficult to point out error in future | 21:17 |
| tbm | yeah, I think so | 21:17 |
| tgnit | tbm: Bug 781? | 21:21 |
| tbm | yes and/or 992 | 21:24 |
| tgnit | tbm: please review | 21:38 |
| tbm | url? | 21:40 |
| tgnit | same as before | 21:42 |
| tbm | tgnit: if(com | 21:55 |
| tbm | space | 21:55 |
| tgnit | sorry | 21:56 |
| tbm | +void instance_t::commodity_precision_directive(commodity_t& comm,string precise) | 21:56 |
| tbm | space before 'string precise' | 21:56 |
| tbm | can you add a blank line at the end of all tests | 21:56 |
| tgnit | ok | 21:57 |
| tbm | I've to test the patch later | 21:57 |
| tgnit | ok, sorry that you had to dictate almost each formatting | 21:59 |
| tgnit | done | 22:10 |
| *** tgnitidle has joined #npoacct | 22:52 | |
| *** tgnit has quit IRC | 22:54 | |
| *** mlncn has quit IRC | 23:29 | |
| *** nesciens has joined #npoacct | 23:31 | |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!