| *** mlncn has joined #npoacct | 00:56 | |
| *** bkuhn is now known as bkuhnIdle | 01:20 | |
| *** mlncn has quit IRC | 01:36 | |
| *** bkuhnIdle is now known as bkuhn | 01:56 | |
| *** mlncn has joined #npoacct | 02:05 | |
| *** garrison has joined #npoacct | 02:22 | |
| *** bkuhn has quit IRC | 03:07 | |
| *** mlncn has quit IRC | 03:16 | |
| *** mlncn has joined #npoacct | 03:24 | |
| *** mlncn has quit IRC | 03:30 | |
| *** garrison has quit IRC | 03:57 | |
| *** garrison has joined #npoacct | 04:11 | |
| *** mlncn has joined #npoacct | 04:16 | |
| *** mlncn has quit IRC | 05:12 | |
| *** jelmer has quit IRC | 05:12 | |
| *** tbm has quit IRC | 05:12 | |
| *** garrison has quit IRC | 05:12 | |
| *** mlinksva has quit IRC | 05:12 | |
| *** joar has quit IRC | 05:12 | |
| *** tgnit has quit IRC | 05:12 | |
| *** nesciens has quit IRC | 05:12 | |
| *** ChanServ has quit IRC | 05:12 | |
| *** mlncn has joined #npoacct | 05:20 | |
| *** garrison has joined #npoacct | 05:20 | |
| *** tgnit has joined #npoacct | 05:20 | |
| *** nesciens has joined #npoacct | 05:20 | |
| *** jelmer has joined #npoacct | 05:20 | |
| *** tbm has joined #npoacct | 05:20 | |
| *** mlinksva has joined #npoacct | 05:20 | |
| *** joar has joined #npoacct | 05:20 | |
| *** dickson.freenode.net sets mode: +o joar | 05:20 | |
| *** ChanServ has joined #npoacct | 05:23 | |
| *** dickson.freenode.net sets mode: +o ChanServ | 05:23 | |
| *** garrison has quit IRC | 05:42 | |
| *** mlncn has quit IRC | 07:38 | |
| *** mlncn has joined #npoacct | 07:58 | |
| *** mlncn has quit IRC | 09:50 | |
| *** bkuhn has joined #npoacct | 11:45 | |
| *** ChanServ has quit IRC | 11:55 | |
| *** jelmer has quit IRC | 11:56 | |
| *** tbm has quit IRC | 11:56 | |
| *** mlinksva has quit IRC | 11:56 | |
| *** bkuhn has quit IRC | 11:56 | |
| *** joar has quit IRC | 11:56 | |
| *** tgnit has quit IRC | 11:56 | |
| *** nesciens has quit IRC | 11:56 | |
| *** paroneayea has quit IRC | 11:56 | |
| *** scott_gonzalez has quit IRC | 11:56 | |
| *** paroneayea has joined #npoacct | 12:03 | |
| *** bkuhnIdle has joined #npoacct | 12:03 | |
| *** ChanServ has joined #npoacct | 12:03 | |
| *** joar has joined #npoacct | 12:03 | |
| *** mlinksva has joined #npoacct | 12:03 | |
| *** tbm has joined #npoacct | 12:03 | |
| *** jelmer has joined #npoacct | 12:03 | |
| *** nesciens has joined #npoacct | 12:03 | |
| *** tgnit has joined #npoacct | 12:03 | |
| *** dickson.freenode.net sets mode: +oo ChanServ joar | 12:03 | |
| *** scott_gonzalez has joined #npoacct | 12:03 | |
| *** bkuhnIdle is now known as bkuhn | 12:54 | |
| *** mlncn has joined #npoacct | 14:12 | |
| *** mlncn has quit IRC | 14:19 | |
| *** bkuhn is now known as bkuhnIdle | 14:21 | |
| *** bkuhnIdle is now known as bkuhn | 14:55 | |
| tgnit | bkuhn: greetings! | 14:57 |
|---|---|---|
| bkuhn | greetings. | 14:58 |
| tgnit | bkuhn: did you check the report? | 15:00 |
| bkuhn | I'll take a look now. | 15:07 |
| tgnit | ok | 15:08 |
| *** mlncn has joined #npoacct | 15:12 | |
| bkuhn | tgnit: ok, I'm lookking at the coverage report now. | 15:31 |
| bkuhn | tgnit: what do you think about spending the rest of your GSoC time trying to get that coverage up to as close to 100% as we can go? | 15:32 |
| tgnit | bkuhn: i am okay with it? and about the patch? | 15:33 |
| bkuhn | tgnit: well, we should finish the patch too. | 15:33 |
| bkuhn | What's the status on that? | 15:33 |
| bkuhn | (Has it been submitted upstream? Or, are you still looking for that bug you and tbm were talking about?) | 15:33 |
| tgnit | i looked on the bug, it is not due to what i think, as tbm said it require larger changes. | 15:34 |
| bkuhn | tbm: ping? | 15:34 |
| bkuhn | tgnit: And your patch causes the bug to happen (i.e., it's not there already without your patch)? | 15:35 |
| tgnit | bkuhn: i am analysing and i found some possible places to restructure | 15:36 |
| bkuhn | tgnit: ok, that's definitely worth the work for sure. If you are not completely stuck on it. | 15:36 |
| tgnit | its not a bug but needs restructuring to avoid showing rounding error in balance with large number of transactions | 15:37 |
| tgnit | bkuhn : not completely stuck but it will eat up coverage time of this week. | 15:38 |
| tgnit | bkuhn: what files do you think needs more coverage? | 15:38 |
| bkuhn | tgnit: Ideally, we'd have 100% coverage. | 15:39 |
| bkuhn | tgnit: I would suggest that you focus on files that have almost no coverage and start there. | 15:39 |
| bkuhn | tgnit: I'd really like you to complete the patch -- it's an important part of your project. | 15:40 |
| bkuhn | I think realistically, given the time in the rest of the program: | 15:40 |
| bkuhn | you should be able to finish that patch and do a good amount of tests as well. | 15:40 |
| tgnit | tgnit: but are they important? | 15:40 |
| bkuhn | tgnit: have you talked with johnw about the issue? | 15:40 |
| tgnit | bkuhn: i too hope the same | 15:40 |
| bkuhn | tgnit: well, I think all of it is important. | 15:40 |
| tgnit | johnw is not available till next Wednesday | 15:41 |
| tgnit | bkuhn: ok | 15:41 |
| tgnit | i hope to solve it before that time | 15:41 |
| bkuhn | ok. | 15:42 |
| bkuhn | anyway, for the code coverage: | 15:42 |
| bkuhn | tgnit: I suggest for the code coverage to pick some files that you can make big strides in covering. | 15:42 |
| bkuhn | If you think a particular area is not used often, then feel free to ask me and tbm before diving into it. | 15:43 |
| tgnit | bkuhn: hmm | 15:43 |
| tbm | coverage how? with test cases? | 15:43 |
| bkuhn | tbm: yes, that's what I'm talking about | 15:44 |
| tbm | ok | 15:44 |
| bkuhn | tbm: tgnit ran lcov for the gcov data from ledger | 15:44 |
| bkuhn | and generated a report. | 15:44 |
| bkuhn | It's in his fork of the ledgerl-cli-npo project. | 15:44 |
| bkuhn | tgnit: I think you should pick an area of the code that interests you that currently has < 60% coverage and see how much larger you can make it by writing more tests. | 15:45 |
| tgnit | tbm: the issue we were talking about is not due to price rounding, i am yet to try some things that i hope will fix it. | 15:45 |
| bkuhn | tgnit: also, another idea: it would be useful if ledger could generate the lcov report from acprep | 15:46 |
| tgnit | bkuhn: ok | 15:46 |
| bkuhn | so you might want to do that first. | 15:46 |
| bkuhn | those are my ideas of where you can proceed, within that, I'm sure there's plenty of work to find. :) | 15:46 |
| tgnit | bkuhn: it already hav gcov configuration but somehow its not working for me. may be because it require clang and i use gcc | 15:47 |
| bkuhn | tgnit: hmm, there you go -- maybe figure out why it doesn't work with gcc and offer a patch that makes it work?? | 15:47 |
| tgnit | bkuhn: got you, i can surely try that | 15:47 |
| bkuhn | Let me know if you get stuck. Let's check back in in a day or two... it sounds like you should be able to at least make progress on the patch by then, and if not, something related to the tests ideas mentioned above. | 15:48 |
| tgnit | absolutely :) | 15:48 |
| *** mlncn has quit IRC | 16:01 | |
| *** mlncn has joined #npoacct | 16:02 | |
| *** mlncn has quit IRC | 16:08 | |
| *** mlncn has joined #npoacct | 16:13 | |
| *** mlncn has quit IRC | 16:54 | |
| *** mlncn has joined #npoacct | 17:49 | |
| *** mlncn has quit IRC | 18:36 | |
| *** mlncn has joined #npoacct | 18:41 | |
| *** mlncn has quit IRC | 19:22 | |
| *** bkuhn is now known as bkuhnIdle | 19:25 | |
| *** bkuhnIdle is now known as bkuhn | 19:55 | |
| *** mlncn has joined #npoacct | 20:44 | |
| *** mlncn has quit IRC | 23:31 | |
| *** mlncn has joined #npoacct | 23:31 | |
| *** mlncn has quit IRC | 23:45 | |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!