*** bkuhn is now known as bkuhnIdle | 00:57 | |
*** bkuhnIdle is now known as bkuhn | 01:51 | |
*** bkuhn has quit IRC | 03:47 | |
*** mlncn has quit IRC | 08:03 | |
*** garrison has quit IRC | 08:21 | |
*** tgnit has quit IRC | 13:32 | |
*** tgnit has joined #npoacct | 14:02 | |
*** mlncn has joined #npoacct | 14:31 | |
*** bkuhn has joined #npoacct | 15:24 | |
tgnit | bkuhn: ping? | 15:30 |
---|---|---|
bkuhn | tgnit: pong! | 15:30 |
bkuhn | how's it going? | 15:30 |
tgnit | its going great | 15:31 |
bkuhn | Did you get the patch submitted upstream? | 15:31 |
tgnit | first thing first, the patch passes all the tests but there is another problem, the known rounding error introduced per posting is showing up in the total which logically shouldn't | 15:32 |
tgnit | i haven't submitted yet | 15:32 |
tgnit | i have discussed with tbm and i felt it is due to another issue so i am looking at it | 15:33 |
tgnit | i discussed with johnw to find that ledger has an option of gcov to with acprep to prepare build for coverage | 15:34 |
tgnit | bkuhn: but that didn't work for me. i tried something else | 15:34 |
tgnit | i have uploaded an xml report of coverage to npo ledger repo | 15:35 |
tgnit | and i have lcov generated html reports with me | 15:36 |
tgnit | code coverage currently stands at around 70% but it is composed of lot of things, so i think you should take a look at it | 15:37 |
tgnit | bkuhn: what about you? | 15:39 |
bkuhn | I'm looking at the code coverage thing now. | 15:45 |
tgnit | bkuhn: shall i upload the whole report folder , its html report? | 15:47 |
bkuhn | if you want, although, I'm not sure what you want me to look at. | 15:47 |
bkuhn | "but it is composed of lot of things, so i think you should take a look at it" That part I don't really understand. | 15:48 |
tgnit | i want you to look at various files covered, which are important and need more tests to improve coverage. | 15:48 |
tgnit | coverage report include library files too | 15:49 |
bkuhn | ah I understand | 15:49 |
bkuhn | go ahead and commit the other report | 15:49 |
tgnit | in my fork or original repo? | 15:49 |
bkuhn | wherever, just put it somewhere I can look at it. The HTML version is easier, definitely. | 15:51 |
tgnit | its 46 mb so i put it at https://gitorious. org/tripuns-npo-ledger-cli/ | 15:56 |
tgnit | after you have downloaded it. when you open the report folder , go to ledger/src/ via index.html | 15:58 |
bkuhn | ok, grabbing it now | 16:00 |
*** mlncn has quit IRC | 16:20 | |
*** mlncn has joined #npoacct | 16:54 | |
*** bkuhn is now known as bkuhnIdle | 19:37 | |
*** bkuhnIdle is now known as bkuhn | 19:58 | |
*** tgnit has quit IRC | 20:25 | |
*** tgnit has joined #npoacct | 20:28 | |
*** mlncn has quit IRC | 21:56 | |
*** mlncn has joined #npoacct | 21:57 | |
*** mlncn has quit IRC | 23:44 |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!