*** mlncn-agaric has quit IRC | 01:08 | |
*** bkuhn is now known as bkuhnIdle | 01:22 | |
*** bkuhnIdle is now known as bkuhn | 02:24 | |
*** bkuhn has quit IRC | 02:48 | |
*** mlncn-agaric has joined #npoacct | 03:27 | |
*** tgnit has quit IRC | 07:37 | |
*** tgnit has joined #npoacct | 07:38 | |
*** tgnit has joined #npoacct | 07:38 | |
*** tgnit has quit IRC | 08:01 | |
*** tgnit has joined #npoacct | 08:01 | |
*** tgnit has quit IRC | 10:53 | |
*** tgnit has joined #npoacct | 11:04 | |
*** bkuhn has joined #npoacct | 13:41 | |
*** mlncn-agaric has quit IRC | 14:24 | |
*** tgnit has quit IRC | 14:47 | |
*** tgnit has joined #npoacct | 14:48 | |
*** mlncn-agaric has joined #npoacct | 15:20 | |
*** mlncn-agaric is now known as mlncn | 15:20 | |
tgnit | bkuhn : greetings! | 15:40 |
---|---|---|
bkuhn | greetings. | 15:40 |
tgnit | hey, i talked to tbm but he will not have time to test precision feature. will you try it? | 15:51 |
tgnit | bkuhn: i am waiting for any comment on pull request regarding tests i submit. maybe johnw is also busy | 15:52 |
bkuhn | tgnit: Ok, I can ping him. | 15:52 |
bkuhn | tgnit: you submitted the precision feature as well? | 15:53 |
bkuhn | has johnw still not rejected that? | 15:53 |
tgnit | nope | 15:53 |
bkuhn | tgnit: Ok, I will ping johnw today about all of it, and review your test PR's as well. Can you email me the URL of your test PRs? | 15:54 |
bkuhn | (and all your tests are in your fork on github as well?) | 15:54 |
tgnit | bkuhn: ok | 15:54 |
tgnit | yes, they are | 15:54 |
tgnit | bkuhn: just curious if that precision feature will be of any use to you? | 15:55 |
tgnit | so eager to get it tried :) | 15:55 |
bkuhn | tgnit: I understand. I am reluctant to use it if we can't get johnw to upstream it. It was a tough feature and complicated. | 15:56 |
bkuhn | If you have time to work on it after GSoC we could look into it further, but at this point, it'll be tough since we know johnw won't take it. | 15:56 |
bkuhn | Sometimes these things happen. | 15:56 |
bkuhn | but I'll talk to him about taking the tests. | 15:57 |
tgnit | ok, there is a comment by tbm on test pull request 312 , my mistake had no notification on it. | 15:57 |
bkuhn | ok, I'll look at all your PR's later today. | 15:58 |
bkuhn | But if you want to fix that comment in time, feel free. | 15:58 |
*** tgnit has quit IRC | 16:04 | |
*** tgnit has joined #npoacct | 16:13 | |
*** bkuhn has quit IRC | 18:37 | |
*** tgnit has quit IRC | 18:57 | |
*** tgnit has joined #npoacct | 19:54 | |
*** bkuhn has joined #npoacct | 20:05 | |
*** mlncn has quit IRC | 21:12 | |
tgnit | bkuhn: fixed on tbm comments, pull request is 313 . | 21:27 |
bkuhn | Thanks. | 21:28 |
*** mlncn has joined #npoacct | 21:30 | |
*** mlinksva_ is now known as mlinksva | 23:08 |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!