Friday, 2014-07-11

*** tgnitidle has quit IRC00:32
*** tbm has quit IRC00:32
*** nesciens has quit IRC00:33
*** jelmer has quit IRC00:33
*** scott_gonzalez has quit IRC00:33
*** bkuhn has quit IRC00:33
*** paroneayea has quit IRC00:33
*** joar has quit IRC00:33
*** ChanServ has quit IRC00:33
*** joar|pi has quit IRC00:33
*** mlinksva has quit IRC00:33
*** tgnit has joined #npoacct00:36
*** nesciens has joined #npoacct00:36
*** bkuhn has joined #npoacct00:36
*** tbm has joined #npoacct00:36
*** scott_gonzalez has joined #npoacct00:36
*** jelmer has joined #npoacct00:36
*** joar has joined #npoacct00:36
*** paroneayea has joined #npoacct00:36
*** ChanServ has joined #npoacct00:36
*** dickson.freenode.net sets mode: +oo joar ChanServ00:36
*** joar|pi has joined #npoacct00:36
*** mlinksva has joined #npoacct00:36
*** bkuhn is now known as bkuhnIdle01:02
*** mlncn has joined #npoacct01:36
*** nesciens has quit IRC02:01
*** mlncn has quit IRC02:34
*** mlncn has joined #npoacct03:06
*** joar|pi has quit IRC03:27
*** mlinksva has quit IRC03:27
*** tgnit has quit IRC03:27
*** tbm has quit IRC03:27
*** jelmer has quit IRC03:27
*** scott_gonzalez has quit IRC03:27
*** bkuhnIdle has quit IRC03:27
*** paroneayea has quit IRC03:27
*** mlncn has quit IRC03:27
*** joar has quit IRC03:27
*** ChanServ has quit IRC03:27
*** joar has joined #npoacct03:58
*** mlncn has joined #npoacct03:58
*** jelmer has joined #npoacct03:58
*** scott_gonzalez has joined #npoacct03:58
*** dickson.freenode.net sets mode: +o joar03:58
*** joar|pi has joined #npoacct04:03
*** mlinksva has joined #npoacct04:03
*** paroneayea has joined #npoacct04:06
*** tgnit has joined #npoacct04:08
*** tbm has joined #npoacct04:08
*** ChanServ has joined #npoacct04:20
*** dickson.freenode.net sets mode: +o ChanServ04:20
*** mlncn has quit IRC05:30
*** tgnit has quit IRC06:48
*** tgnit has joined #npoacct07:00
*** tgnit has quit IRC07:07
*** tgnit has joined #npoacct07:09
*** nesciens has joined #npoacct11:19
*** mlncn has joined #npoacct14:27
*** mlncn has quit IRC14:45
*** mlncn has joined #npoacct16:00
*** nesciens has quit IRC16:04
*** tgnit has quit IRC17:10
*** mlncn has quit IRC17:15
*** mlncn has joined #npoacct17:21
*** garrison has joined #npoacct17:27
*** garrison has joined #npoacct17:27
*** tgnit has joined #npoacct17:44
*** tgnit has quit IRC17:48
*** tgnit has joined #npoacct17:53
*** bkuhn has joined #npoacct17:55
*** jelmer has quit IRC17:56
*** bkuhn has quit IRC18:01
*** bkuhn has joined #npoacct18:03
*** garrison has quit IRC18:05
*** garrison has joined #npoacct18:13
*** garrison has joined #npoacct18:13
tgnitbkuhn:  shall i make  a pull request since formatting is done or shall we wait for tbm to test?18:35
tbmtgnit: I can test it now18:37
tgnitsure18:37
bkuhnyeah, let's wait for tbm to test.18:41
bkuhnTHanks tbm for doing that!18:41
*** garrison has quit IRC18:51
tbmok, compiling now18:55
tbmtgnit: found another issue19:12
tbmcommodity GBP19:12
tbm   precision 219:12
tbm19:12
tbm2012-04-30 * Interest19:12
tbm     Assets:Savings                          0.34 GBP19:12
tbm     Income:Interest                        -0.43 GBP19:12
tbm     Expenses:Tax:Interest                   0.09 GBP19:12
tbmWhile balancing transaction from "/home/tbm/tmp/src/ledger/tripun/ledger/t", lines 7-10:19:12
tbm> 2012-04-30 * Interest19:12
tbm>      Assets:Savings                          0.34 GBP19:12
tbm>      Income:Interest                        -0.43 GBP19:12
tbm>      Expenses:Tax:Interest                   0.09 GBP19:12
tbmUnbalanced remainder is:19:12
tbm            0.00 GBP19:12
tbmAmount to balance against:19:12
tbm            0.43 GBP19:12
tbmError: Transaction does not balance19:12
tgnitlet me check19:13
*** tgnit has quit IRC19:30
*** mlncn-agaric has joined #npoacct19:37
*** tgnit has joined #npoacct19:39
*** mlncn has quit IRC19:41
*** scott_gonzalez has quit IRC19:41
*** scott_gonzalez has joined #npoacct19:43
*** bkuhn is now known as bkuhnIdle20:01
tgnittbm: confirmed,  i am on it.20:09
*** jelmer has joined #npoacct20:09
tbmtgnit: cool20:25
*** bkuhnIdle is now known as bkuhn20:33
tgnittbm: found the problem,  balance amount display value is not zero21:25
tgnitdisplay problem,  although i found a spot but it is redundant so digging deeper21:26
tgniti suspect the variables used in calculations and display are different,  i am checking21:44
tgnittbm: solved, just checking to avoid redundant calls23:06
bkuhntgnit: Also, I assume that the entire test suite passes (i.e., no regressions?)23:07
tgnitbkuhn: yes23:07
bkuhnOk, once that's true and tbm has signed off, I'd say to go ahead and submit the merge request.23:08
tgnitbkuhn:  i don't get that many issues just because i rely only on test suite,  i don't have ledger data of my pwn, any help?23:08
bkuhntgnit: At the moment, just make sure it passes the ledger-cli test suit that's there... if it passes that, that's enough to submit the pull request upstream23:24
tgnitok23:25
tgnitbkuhn:  should i submit this fix as new commit or just edit and add to previous.  since i have not released anything from precision branch23:26
bkuhntgnit: I think it's fine to offer a pull request with lots of commits in it, as long as the final thing submitting adheres to the coding standards, passes the entire test suite (including your new test), and tbm says it "works". :)23:27
tgnitbkuhn: :)23:28

Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!