| *** tgnitidle has quit IRC | 00:32 | |
| *** tbm has quit IRC | 00:32 | |
| *** nesciens has quit IRC | 00:33 | |
| *** jelmer has quit IRC | 00:33 | |
| *** scott_gonzalez has quit IRC | 00:33 | |
| *** bkuhn has quit IRC | 00:33 | |
| *** paroneayea has quit IRC | 00:33 | |
| *** joar has quit IRC | 00:33 | |
| *** ChanServ has quit IRC | 00:33 | |
| *** joar|pi has quit IRC | 00:33 | |
| *** mlinksva has quit IRC | 00:33 | |
| *** tgnit has joined #npoacct | 00:36 | |
| *** nesciens has joined #npoacct | 00:36 | |
| *** bkuhn has joined #npoacct | 00:36 | |
| *** tbm has joined #npoacct | 00:36 | |
| *** scott_gonzalez has joined #npoacct | 00:36 | |
| *** jelmer has joined #npoacct | 00:36 | |
| *** joar has joined #npoacct | 00:36 | |
| *** paroneayea has joined #npoacct | 00:36 | |
| *** ChanServ has joined #npoacct | 00:36 | |
| *** dickson.freenode.net sets mode: +oo joar ChanServ | 00:36 | |
| *** joar|pi has joined #npoacct | 00:36 | |
| *** mlinksva has joined #npoacct | 00:36 | |
| *** bkuhn is now known as bkuhnIdle | 01:02 | |
| *** mlncn has joined #npoacct | 01:36 | |
| *** nesciens has quit IRC | 02:01 | |
| *** mlncn has quit IRC | 02:34 | |
| *** mlncn has joined #npoacct | 03:06 | |
| *** joar|pi has quit IRC | 03:27 | |
| *** mlinksva has quit IRC | 03:27 | |
| *** tgnit has quit IRC | 03:27 | |
| *** tbm has quit IRC | 03:27 | |
| *** jelmer has quit IRC | 03:27 | |
| *** scott_gonzalez has quit IRC | 03:27 | |
| *** bkuhnIdle has quit IRC | 03:27 | |
| *** paroneayea has quit IRC | 03:27 | |
| *** mlncn has quit IRC | 03:27 | |
| *** joar has quit IRC | 03:27 | |
| *** ChanServ has quit IRC | 03:27 | |
| *** joar has joined #npoacct | 03:58 | |
| *** mlncn has joined #npoacct | 03:58 | |
| *** jelmer has joined #npoacct | 03:58 | |
| *** scott_gonzalez has joined #npoacct | 03:58 | |
| *** dickson.freenode.net sets mode: +o joar | 03:58 | |
| *** joar|pi has joined #npoacct | 04:03 | |
| *** mlinksva has joined #npoacct | 04:03 | |
| *** paroneayea has joined #npoacct | 04:06 | |
| *** tgnit has joined #npoacct | 04:08 | |
| *** tbm has joined #npoacct | 04:08 | |
| *** ChanServ has joined #npoacct | 04:20 | |
| *** dickson.freenode.net sets mode: +o ChanServ | 04:20 | |
| *** mlncn has quit IRC | 05:30 | |
| *** tgnit has quit IRC | 06:48 | |
| *** tgnit has joined #npoacct | 07:00 | |
| *** tgnit has quit IRC | 07:07 | |
| *** tgnit has joined #npoacct | 07:09 | |
| *** nesciens has joined #npoacct | 11:19 | |
| *** mlncn has joined #npoacct | 14:27 | |
| *** mlncn has quit IRC | 14:45 | |
| *** mlncn has joined #npoacct | 16:00 | |
| *** nesciens has quit IRC | 16:04 | |
| *** tgnit has quit IRC | 17:10 | |
| *** mlncn has quit IRC | 17:15 | |
| *** mlncn has joined #npoacct | 17:21 | |
| *** garrison has joined #npoacct | 17:27 | |
| *** garrison has joined #npoacct | 17:27 | |
| *** tgnit has joined #npoacct | 17:44 | |
| *** tgnit has quit IRC | 17:48 | |
| *** tgnit has joined #npoacct | 17:53 | |
| *** bkuhn has joined #npoacct | 17:55 | |
| *** jelmer has quit IRC | 17:56 | |
| *** bkuhn has quit IRC | 18:01 | |
| *** bkuhn has joined #npoacct | 18:03 | |
| *** garrison has quit IRC | 18:05 | |
| *** garrison has joined #npoacct | 18:13 | |
| *** garrison has joined #npoacct | 18:13 | |
| tgnit | bkuhn: shall i make a pull request since formatting is done or shall we wait for tbm to test? | 18:35 |
|---|---|---|
| tbm | tgnit: I can test it now | 18:37 |
| tgnit | sure | 18:37 |
| bkuhn | yeah, let's wait for tbm to test. | 18:41 |
| bkuhn | THanks tbm for doing that! | 18:41 |
| *** garrison has quit IRC | 18:51 | |
| tbm | ok, compiling now | 18:55 |
| tbm | tgnit: found another issue | 19:12 |
| tbm | commodity GBP | 19:12 |
| tbm | precision 2 | 19:12 |
| tbm | 19:12 | |
| tbm | 2012-04-30 * Interest | 19:12 |
| tbm | Assets:Savings 0.34 GBP | 19:12 |
| tbm | Income:Interest -0.43 GBP | 19:12 |
| tbm | Expenses:Tax:Interest 0.09 GBP | 19:12 |
| tbm | While balancing transaction from "/home/tbm/tmp/src/ledger/tripun/ledger/t", lines 7-10: | 19:12 |
| tbm | > 2012-04-30 * Interest | 19:12 |
| tbm | > Assets:Savings 0.34 GBP | 19:12 |
| tbm | > Income:Interest -0.43 GBP | 19:12 |
| tbm | > Expenses:Tax:Interest 0.09 GBP | 19:12 |
| tbm | Unbalanced remainder is: | 19:12 |
| tbm | 0.00 GBP | 19:12 |
| tbm | Amount to balance against: | 19:12 |
| tbm | 0.43 GBP | 19:12 |
| tbm | Error: Transaction does not balance | 19:12 |
| tgnit | let me check | 19:13 |
| *** tgnit has quit IRC | 19:30 | |
| *** mlncn-agaric has joined #npoacct | 19:37 | |
| *** tgnit has joined #npoacct | 19:39 | |
| *** mlncn has quit IRC | 19:41 | |
| *** scott_gonzalez has quit IRC | 19:41 | |
| *** scott_gonzalez has joined #npoacct | 19:43 | |
| *** bkuhn is now known as bkuhnIdle | 20:01 | |
| tgnit | tbm: confirmed, i am on it. | 20:09 |
| *** jelmer has joined #npoacct | 20:09 | |
| tbm | tgnit: cool | 20:25 |
| *** bkuhnIdle is now known as bkuhn | 20:33 | |
| tgnit | tbm: found the problem, balance amount display value is not zero | 21:25 |
| tgnit | display problem, although i found a spot but it is redundant so digging deeper | 21:26 |
| tgnit | i suspect the variables used in calculations and display are different, i am checking | 21:44 |
| tgnit | tbm: solved, just checking to avoid redundant calls | 23:06 |
| bkuhn | tgnit: Also, I assume that the entire test suite passes (i.e., no regressions?) | 23:07 |
| tgnit | bkuhn: yes | 23:07 |
| bkuhn | Ok, once that's true and tbm has signed off, I'd say to go ahead and submit the merge request. | 23:08 |
| tgnit | bkuhn: i don't get that many issues just because i rely only on test suite, i don't have ledger data of my pwn, any help? | 23:08 |
| bkuhn | tgnit: At the moment, just make sure it passes the ledger-cli test suit that's there... if it passes that, that's enough to submit the pull request upstream | 23:24 |
| tgnit | ok | 23:25 |
| tgnit | bkuhn: should i submit this fix as new commit or just edit and add to previous. since i have not released anything from precision branch | 23:26 |
| bkuhn | tgnit: I think it's fine to offer a pull request with lots of commits in it, as long as the final thing submitting adheres to the coding standards, passes the entire test suite (including your new test), and tbm says it "works". :) | 23:27 |
| tgnit | bkuhn: :) | 23:28 |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!