| tbm | "I assume that the entire test suite passes" | 00:00 |
|---|---|---|
| tbm | the problem with that is that tgnit's patch doesn't do anything unless you add "commodity .. precision" directive | 00:01 |
| tbm | tgnit: I don't see your latest fix. did you push it? | 00:01 |
| tgnit | tbm: i do not find many issues because I don't have much ledger data except test suite which i have not edited to add precision directive | 00:02 |
| tgnit | no not yet | 00:02 |
| tgnit | just a minute | 00:02 |
| tbm | I have lots of ledger data to run tests on | 00:03 |
| bkuhn | tbm: well, tgnit is adding one test to test the directive... | 00:04 |
| bkuhn | .... and the rest is to make sure that behavior of *not* adding the directive stays the same | 00:04 |
| tgnit | tbm: pushed | 00:08 |
| tgnit | tbm: there is one call which is redundant but still useful, can we discuss this on the commit i reverted on debug branch just now? | 00:20 |
| tbm | tgnit: here's another problem | 00:23 |
| tbm | commodity EUR | 00:24 |
| tbm | precision 2 | 00:24 |
| tbm | 00:24 | |
| tbm | 2010-08-02 * ATM (Glasgow) | 00:24 |
| tbm | Assets:Current -38.24 EUR | 00:24 |
| tbm | Assets:Cash 30.00 GBP | 00:24 |
| tbm | Expenses:Fees:Bank 2.09 EUR | 00:24 |
| tbm | Unbalanced remainder is: | 00:24 |
| tbm | 0.00 EUR | 00:24 |
| tbm | Amount to balance against: | 00:24 |
| tbm | 31.73 GBP | 00:24 |
| tgnit | tbm: checking | 00:25 |
| tgnit | tbm: it is automatically converting eur to gbp? how? | 00:34 |
| tbm | tgnit: yes, ledger can do this if you only have 2 currencies | 00:39 |
| tgnit | hmm, thanks for bringing up interesting cases :) | 00:40 |
| bkuhn | Sounds like the above needs to be one the test cases we submit with this patch! | 00:46 |
| tgnit | tbm: it is contradictory, the above feature shall not work for commodities not mentioning precision sub directiive | 00:47 |
| tgnit | if instead of eur you mention it for gbp it works because that is chosen commodity | 00:47 |
| tgnit | so commodity gbp | 00:48 |
| tgnit | instead of conmodity eur should work | 00:48 |
| tgnit | bkuhn: right, i will keep adding test cases as they come | 00:49 |
| tgnit | bkuhn: i think this one shall be listed as known issue | 00:49 |
| tgnit | tbm: is there a way you set eur as default commodity and it does not get overridden | 00:51 |
| tgnit | ? | 00:51 |
| *** bkuhn is now known as bkuhnIdle | 01:12 | |
| tbm | tgnit: in my original case, I had both | 01:15 |
| tbm | commodity GBP | 01:15 |
| tbm | precision 2 | 01:15 |
| tbm | and | 01:15 |
| tbm | commodity EUR | 01:16 |
| tbm | precision 2 | 01:16 |
| tbm | because this is what I want | 01:16 |
| tbm | and this will trigger this bug | 01:16 |
| tgnit | ok | 01:16 |
| tgnit | it is triggering without it too | 01:16 |
| tgnit | and just gbp precision works | 01:17 |
| tgnit | but i will check | 01:17 |
| *** bkuhnIdle is now known as bkuhn | 02:02 | |
| *** bkuhn has quit IRC | 02:27 | |
| *** mlncn-agaric has quit IRC | 02:47 | |
| *** mlncn-agaric has joined #npoacct | 03:30 | |
| *** mlncn-agaric has quit IRC | 04:19 | |
| *** mlncn-agaric has joined #npoacct | 04:27 | |
| *** mlncn-agaric has quit IRC | 06:10 | |
| *** tgnit has quit IRC | 07:55 | |
| *** tgnit has joined #npoacct | 07:58 | |
| *** tgnit has quit IRC | 08:12 | |
| *** tgnit has joined #npoacct | 08:31 | |
| *** tgnit has quit IRC | 08:38 | |
| *** tgnit has joined #npoacct | 08:39 | |
| tgnit | tbm: pushed new fix and tests please check | 12:35 |
| tbm | tgnit: great | 13:19 |
| tgnit | tbm: thanks, did you check? | 13:25 |
| tbm | working on it | 13:27 |
| tbm | hm, there's at least one issue but it's diffcult to generate a test case | 13:46 |
| tgnit | hmm, any possible description? | 13:51 |
| tgnit | tbm: why do you think there is an issue, did anything went wrong? | 13:52 |
| tbm | yes, getting wrong results | 13:52 |
| tgnit | tbm: any guess why or where? | 13:59 |
| *** jelmer has quit IRC | 14:06 | |
| *** tbm has quit IRC | 14:06 | |
| *** joar|pi has quit IRC | 14:06 | |
| *** mlinksva has quit IRC | 14:06 | |
| *** joar has quit IRC | 14:06 | |
| *** jelmer has joined #npoacct | 14:07 | |
| *** tbm has joined #npoacct | 14:07 | |
| *** mlinksva has joined #npoacct | 14:07 | |
| *** joar|pi has joined #npoacct | 14:07 | |
| *** joar has joined #npoacct | 14:07 | |
| *** dickson.freenode.net sets mode: +o joar | 14:07 | |
| tbm | tgnit: I sent you my example by email | 14:15 |
| tgnit | tbm: ok | 14:15 |
| *** tgnit has quit IRC | 14:47 | |
| *** tgnit has joined #npoacct | 15:10 | |
| *** tgnit has quit IRC | 15:52 | |
| *** tgnit has joined #npoacct | 16:27 | |
| *** tgnit has quit IRC | 17:28 | |
| *** tgnit has joined #npoacct | 17:35 | |
| *** garrison has joined #npoacct | 17:38 | |
| *** nesciens has joined #npoacct | 17:46 | |
| tgnit | tbm: that is not a bug you reported, i replied to your mail with counter example | 19:35 |
| tgnit | tbm: it is known rounding error per posting introduced with rounding | 19:36 |
| tgnit | tbm: price revaluation occurs per posting , while the precision is maintained in original ledger just because it does not round till the end | 19:37 |
| tgnit | it is not total of the conmodity multiplied with current price | 19:37 |
| *** joar|pi has quit IRC | 21:34 | |
| *** tgnit has quit IRC | 22:35 | |
| *** tgnit has joined #npoacct | 22:36 | |
| *** tgnit has quit IRC | 22:40 | |
| *** tgnit has joined #npoacct | 22:41 | |
Generated by irclog2html.py 2.12.1 by Marius Gedminas - find it at mg.pov.lt!